-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 758: Mark as Accepted #4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Wulian233, for the future, we generally we let the PEP author create the PR to mark as accepted, as they might have other tidying up to do. A |
AA-Turner
requested changes
Mar 15, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
approved these changes
Mar 15, 2025
Member
|
Indeed, and there's also a checklist for doing so (added automatically by selecting the correct PR template):
|
Contributor
Author
|
Thank you for the reminder. I have revised the PR description |
hugovk
reviewed
Mar 16, 2025
hugovk
approved these changes
Mar 16, 2025
brettcannon
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statuschanged toAccepted/RejectedResolutionlink points directly to SC/PEP Delegate official acceptance/rejected postDiscussions-To,Post-HistoryandPython-Versionup to date📚 Documentation preview 📚: https://pep-previews--4304.org.readthedocs.build/