Skip to content

Conversation

@emmatyping
Copy link
Member

@emmatyping emmatyping commented Jan 24, 2025

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

I wasn't sure whether this is classified as a meta change or an editorial change, so I just chose editorial.


📚 Documentation preview 📚: https://pep-previews--4229.org.readthedocs.build/

@emmatyping emmatyping requested review from a team and warsaw as code owners January 24, 2025 21:23
@hauntsaninja hauntsaninja merged commit 3cf28aa into python:main Jan 24, 2025
6 checks passed
@hauntsaninja
Copy link
Contributor

Btw, when merging this I noticed your commits are still authored under the previous email

@emmatyping emmatyping deleted the update-name-and-email branch January 24, 2025 22:09
@emmatyping
Copy link
Member Author

Thank you for merging!

I noticed your commits are still authored under the previous email

Yeah, I'm not sure if there is much to be done there without rewriting history, right?

@hauntsaninja
Copy link
Contributor

Sorry, I meant new commits, like the one in this PR. See e.g. https://github.com/python/peps/commit/3cf28aa6675e419e5da861b52788bf10ff4abdef.patch
(I don't know of a viable way to change old commits)

@emmatyping
Copy link
Member Author

Ahh, thank you for pointing that out! I was using an old server I hadn't updated yet

@hugovk
Copy link
Member

hugovk commented Jan 25, 2025

Yeah, I'm not sure if there is much to be done there without rewriting history, right?

It's somewhat possible by adding a .mailmap file to the repo like:

Emma Smith <new@example.com> <old@example.com>

For example:

@emmatyping
Copy link
Member Author

It's somewhat possible by adding a .mailmap file to the repo

True, and I actually thought about this, but that also seems like a lot of noise to introduce a new file to the repo root, especially if it's just for me. I'd rather someone find my old email by accident than telegraph the change. The old email forwards and is still tied to my Github account 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants