PEP 769: Fix some typos and provide some clarity #4192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Viicos
reviewed
Jan 8, 2025
Contributor
Viicos
left a comment
Viicos
left a comment
There was a problem hiding this comment.
I believe using proper Sphinx references will be cleaner, e.g.:
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Contributor
|
I only gave an example, but ideally this should be applied on all the file. I can also do a separate PR. |
Merged
Member
|
(conflict resolved) |
hugovk
approved these changes
Jan 9, 2025
facundobatista
approved these changes
Jan 9, 2025
Member
facundobatista
left a comment
facundobatista
left a comment
There was a problem hiding this comment.
Awesome, thanks for the suggestions!
Member
Author
|
Thanks @facundobatista - been too busy to finish it up, but glad you took over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@facundobatista
Hope you don't mind some tweaking of the wording!
📚 Documentation preview 📚: https://pep-previews--4192.org.readthedocs.build/