PEP 3147: Update figures #4178
Merged
PEP 3147: Update figures #4178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
shallow-beach
commented
Dec 20, 2024
Contributor
Author
shallow-beach
left a comment
shallow-beach
left a comment
There was a problem hiding this comment.
Restored figure sizing so png displays properly in docs.
JelleZijlstra
approved these changes
Mar 3, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a little bit of missing background in the png for the figure, went in and fixed that. To do so, I had to get Dia running on MacOS 15 which was a nightmare (booting the app via XQuartz terminal 🥴), so also rendered out the dia file into an svg for ease of future contributors.
📚 Documentation preview 📚: https://pep-previews--4178.org.readthedocs.build/