Skip to content

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Dec 13, 2024

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

📚 Documentation preview 📚: https://pep-previews--4167.org.readthedocs.build/

@skirpichev skirpichev requested a review from vstinner as a code owner December 13, 2024 15:15
@skirpichev skirpichev marked this pull request as draft December 13, 2024 15:16
@vstinner

This comment was marked as resolved.

@skirpichev skirpichev marked this pull request as ready for review December 13, 2024 16:22
@hugovk
Copy link
Member

hugovk commented Dec 13, 2024

  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Has this PEP been documented at https://docs.python.org/dev/?

If so, please can you link to its documentation using one canonical-doc?

@skirpichev skirpichev requested a review from hugovk December 14, 2024 00:35
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk
Copy link
Member

hugovk commented Dec 15, 2024

By the way, make spellcheck finds these typos, let's fix them at the same time:

peps/pep-0757.rst:485: bufferes ==> buffers, buffered
peps/pep-0757.rst:556: accross ==> across

@vstinner vstinner merged commit cbf8efb into python:main Dec 16, 2024
5 checks passed
@vstinner
Copy link
Member

Merged, thank you.

@skirpichev skirpichev deleted the pep757-final branch December 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants