Skip to content

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Dec 4, 2024

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4153.org.readthedocs.build/

@skirpichev skirpichev requested a review from gpshead December 4, 2024 02:56
@skirpichev skirpichev marked this pull request as ready for review December 6, 2024 23:54
@skirpichev skirpichev requested a review from vstinner as a code owner December 6, 2024 23:54
@vstinner
Copy link
Member

vstinner commented Dec 7, 2024

@gpshead: If you are not convinced, we can simplify the API by removing the .value member. What do you think?

@gpshead
Copy link
Member

gpshead commented Dec 8, 2024

@gpshead: If you are not convinced, we can simplify the API by removing the .value member. What do you think?

No need. Thanks for documenting this. :)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@ncoghlan
Copy link
Contributor

ncoghlan commented Dec 9, 2024

Since the PEP authors both chimed in above, and this PR was mentioned in the SC's approval notice, going ahead and merging the addition.

@ncoghlan ncoghlan merged commit 9d8427e into python:main Dec 9, 2024
5 checks passed
@skirpichev skirpichev deleted the pep757-no-value-edits branch December 9, 2024 02:58
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants