Skip to content

Conversation

@davepeck
Copy link
Contributor

@davepeck davepeck commented Nov 18, 2024

Updates include:

  • Addition of typed convenience accessors to Template, including strings, interpolations, and values.
  • New discussion of the relationship between t-strings and old-style format strings, along with example code
  • Improved discussion of laziness/delayed binding
  • Describe Template.__hash__()
  • Make Template.args explicitly be a tuple
  • Bugfix the description of debug specifier behavior

Thanks to @lysnikolaou @koxudaxi @pauleveritt @jimbaker and everyone in recent discussion threads for all the useful feedback.

I opened a new Discourse thread for this updated PR.


📚 Documentation preview 📚: https://pep-previews--4124.org.readthedocs.build/

@hugovk hugovk changed the title Updates to PEP 750 after community feedback PEP 750: Updates after community feedback Nov 18, 2024
@AA-Turner AA-Turner self-requested a review November 18, 2024 18:40
Copy link

@gvanrossum-ms gvanrossum-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to do a full review of this PR but ran out of time. Here are a few comments I have. In any case, I offer to just merge this PR, so readers of the thread won't have to wonder if their changes are accepted. You can always merge another PR -- there's no particular process to be followed here.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder to review! Nothing particularly major, though a few questions:

A

davepeck and others added 17 commits January 16, 2025 12:34
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@davepeck
Copy link
Contributor Author

Thank you for the reminder to review! Nothing particularly major, though a few questions:

Thanks for all the good catches @AA-Turner -- I think I've addressed all of these. Let me know how things look!

davepeck and others added 3 commits January 16, 2025 14:20
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Are you waiting for any further reviews of this PR, or would you like for it to be merged?

A

@davepeck
Copy link
Contributor Author

Thank you! Are you waiting for any further reviews of this PR, or would you like for it to be merged?

Happy to have it merged!

Thanks again for all your help.

@AA-Turner AA-Turner merged commit 03be803 into python:main Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants