Skip to content

Conversation

@msarahan
Copy link
Contributor

@msarahan msarahan commented Nov 18, 2024

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

📚 Documentation preview 📚: https://pep-previews--4123.org.readthedocs.build/pep-0766/

@ghost
Copy link

ghost commented Nov 18, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovk hugovk added the new-pep A new draft PEP submitted for initial review label Nov 19, 2024
@msarahan
Copy link
Contributor Author

Thanks for the help, @hugovk.

Apply suggestions from code review

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@msarahan msarahan changed the title PEP 766: Define terms for priority strategies among multiple indexes (index priority) PEP 766: Explicit Priority Choices Among Multiple Indexes (index priority) Nov 20, 2024
@msarahan msarahan marked this pull request as ready for review November 20, 2024 04:18
@msarahan msarahan requested a review from a team as a code owner November 20, 2024 04:18
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little nits

Thanks Hugo!

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@msarahan
Copy link
Contributor Author

Anything else needed here, @hugovk ? Barry explained to me that we should try to get this merged, then continue to revise the content according to discussions on discourse.

@hugovk
Copy link
Member

hugovk commented Nov 21, 2024

Yep, if no-one has any comments let's merge! @warsaw: any final review suggestions, or good to merge?

@msarahan Once merged, please open a new discussion topic, then open a quick PR to put that link under Discussions-To, and also append it to Post-History (re: https://peps.python.org/pep-0001/#discussing-a-pep)

@msarahan
Copy link
Contributor Author

Is a new discussion topic necessary? I read that part of PEP 1, but I think the thread at https://discuss.python.org/t/pep-766-handling-multiple-indexes-index-priority/71589 fulfills the purpose described by PEP 1 of being a canonical discussion place, and the thread isn't terribly long (yet?)

I feel like starting a new topic would only spread the existing discussion around more places.

@warsaw
Copy link
Member

warsaw commented Nov 21, 2024

Good from my side, thanks @hugovk. I'll go ahead and merge.

@warsaw warsaw merged commit ac1c66e into python:main Nov 21, 2024
5 checks passed
@msarahan msarahan deleted the index-priority branch November 21, 2024 20:06
@hugovk
Copy link
Member

hugovk commented Nov 21, 2024

Is a new discussion topic necessary? I read that part of PEP 1, but I think the thread at https://discuss.python.org/t/pep-766-handling-multiple-indexes-index-priority/71589 fulfills the purpose described by PEP 1 of being a canonical discussion place, and the thread isn't terribly long (yet?)

Yeah, this is why PEP 1 says to open the canonical discussion after merging the PR and getting the proper PEP URL.

I feel like starting a new topic would only spread the existing discussion around more places.

Fair enough, please could you edit the top post to link to https://peps.python.org/pep-0766/ and not just this PR?

gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
…rity) (python#4123)

* add index priority pep draft

* Address feedback from Barry and Ethan

* PEP 766: explicit priority choices among multiple indexes

Apply suggestions from code review

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

* address feedback from DPO and linting

* revise text

* Apply suggestions from code review

Thanks Hugo!

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

---------

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants