Lint: Normalise whitespace, remove the Emacs stanza, remove unneeded headers #4081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willingc
approved these changes
Oct 28, 2024
hugovk
approved these changes
Oct 28, 2024
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
My proposal would be to temporarily enable rebase merging, rebase-merge this, and then disable it, so that we still have somewhat meaningful individual commits
I'm fine with a squash merge, it's all cleanup.
lysnikolaou
approved these changes
Nov 6, 2024
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM, too! Let's merge this and close #4078.
Member
Author
|
Rebased & updated |
AA-Turner
requested review from
Mariatta,
ambv,
brettcannon,
dhellmann,
dstufft,
ericsnowcurrently,
gpshead,
jackjansen,
njsmith,
pablogsal,
pitrou,
tiran,
vstinner,
warsaw and
zooba
as code owners
AA-Turner
removed request for
CAM-Gerlach,
FFY00,
Fidget-Spinner,
Mariatta,
Yhg1s,
brandtbucher,
brianquinlan,
emilyemorehouse,
erlend-aasland,
ethanfurman,
ezio-melotti,
gvanrossum,
ilevkivskyi,
isidentical,
jackjansen,
jeremyhylton,
larryhastings,
lisroach,
malemburg,
markshannon,
ned-deily,
pablogsal,
pradyunsg,
savannahostrowski,
serhiy-storchaka,
terryjreedy,
tim-one and
zware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #4078.
cc: @hugovk
My proposal would be to temporarily enable rebase merging, rebase-merge this, and then disable it, so that we still have somewhat meaningful individual commits but minimise the number of times people are pinged.
If we merge this, I'll follow up with a PR to the tooling.
A
📚 Documentation preview 📚: https://pep-previews--4081.org.readthedocs.build/