PEP 777: How to Re-invent the Wheel #4036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
Contributor
Author
|
I will also go back and update #3786 now to remove 777, and fixup the review comments there. |
warsaw
approved these changes
Oct 9, 2024
Member
warsaw
left a comment
warsaw
left a comment
There was a problem hiding this comment.
I've seen pre-published versions of the PEP and it LGTM. Other @python/pep-editors will likely provide some feedback before merging.
Contributor
Author
|
Rational for non-sequential numbering is here: #3786 (comment) |
emmatyping
added a commit
to emmatyping/peps
that referenced
this pull request
Oct 9, 2024
The PEP has been split out into python#4036
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Some wording suggestions, all optional.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
emmatyping-nv
changed the title
JelleZijlstra
approved these changes
Oct 9, 2024
hugovk
reviewed
Oct 9, 2024
hugovk
reviewed
Oct 9, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
willingc
reviewed
Oct 9, 2024
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Overall, this looks well done. I've made a few clarification suggestions to aid those who were not part of the discussion.
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
hugovk
approved these changes
Oct 10, 2024
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
See also wheelnext#3 to compress the images.
Compress images with oxipng
gvanrossum
pushed a commit
to gvanrossum/peps
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
warsaw
added a commit
that referenced
this pull request
Jul 9, 2025
* Add PEP 778 and reserve 777 * Add Paul Moore as PEP delegate Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Add Paul Moore as PEP delegate Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Update peps/pep-0778.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Remove extra underline Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Fix misspelling Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Remove PEP 777 The PEP has been split out into #4036 * Add codeowners * Remove third p from suppport Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Mark PEP 778 deferred * Apply suggestions from Barry to PEP text Co-authored-by: Barry Warsaw <barry@python.org> * Fix lint error --------- Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Barry Warsaw <barry@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic requirements (all PEP Types)
PEP has next available number,& set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Discussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4036.org.readthedocs.build/pep-0777/