[mypyc]: support :s and :d in generate_format_ops #20534
+61
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
BobTheBuidler
force-pushed
the
more-ops
branch
from
15c0ea0 to
174af4a
Compare
JukkaL
reviewed
Jan 26, 2026
| def g() -> str: | ||
| return FMT_D.format(400 + 20, "roll" + "up") | ||
| def h() -> str: | ||
| return FMT_S.format(400 + 20, "roll" + "up") |
Collaborator
There was a problem hiding this comment.
In Python, {:s} appears to only support str values. There is no implicit conversion to strings:
>>> '{:s}'.format(2)
Traceback (most recent call last):
File "<python-input-7>", line 1, in <module>
'{:s}'.format(2)
~~~~~~~~~~~~~^^^
ValueError: Unknown format code 's' for object of type 'int'
I think we should have similar checks to support :s in a compatible way, or apply the optimization if the static type of the corresponding operand is builtins.str perhaps.
Contributor
Author
There was a problem hiding this comment.
Updated, how's this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of, and blocked by, #19970.
Will rebase once 19970 is merged and then mark this one as ready.