GH-149501: Fix compilation warning for _YIELD_VALUE

[sergey-miryanov]

Fix warning for MSVC

• Issue: Fix compilation warning for _YIELD_VALUE #149501

[sergey-miryanov]

cc @vstinner as an author of the change

[vstinner]

Would it be possible to change i type to size_t or Py_ssize_t instead?

[vstinner]

Sorry, but in fact I prefer the initial fix: int i = (int)(frame->instr_ptr - _PyFrame_GetBytecode(frame));.

I don't think that changing _Py_GetBaseCodeUnit() parameter type from int to Py_ssize_t is worth it, since PyCode_New() checks indirectly that the size fits into an int:

    if (PyBytes_GET_SIZE(con->code) > INT_MAX) {
        PyErr_SetString(PyExc_OverflowError,
                        "code: co_code larger than INT_MAX");
        return -1;
    }

[sergey-miryanov]

@vstinner
I've updated the intermediate value to use Py_ssize_t and added an assertion to ensure it fits in an int before casting. What do you think? Does this approach look good?

[vstinner]

Yes, I'm fine with the assert() approach.

[sergey-miryanov]

JIT fail seems unrelated to the changes.

[sergey-miryanov]

Thanks all!

[miss-islington-app]

Thanks @sergey-miryanov for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

[bedevere-app]

GH-149737 is a backport of this pull request to the 3.15 branch.