gh-145886: remove unused Event.raw field from _pyrepl#146097
Open
HCYT wants to merge 4 commits intopython:mainfrom
Open
gh-145886: remove unused Event.raw field from _pyrepl#146097HCYT wants to merge 4 commits intopython:mainfrom
HCYT wants to merge 4 commits intopython:mainfrom
Conversation
Event.raw was being accumulated in getpending() but never actually read anywhere -- the callers only ever use Event.data. On top of that, there was a copy-paste bug (e.raw += e.raw instead of e.raw += e2.raw) which went unnoticed precisely because nothing consumes the field. Rather than just fixing the typo, remove the dead field entirely.
missed one with positional raw arg, only runs on windows so the previous test run didn't catch it
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at the
getpending()bug (e.raw += e.rawinstead ofe2.raw), I noticedEvent.rawis never actually read anywhere -- only written to. So instead of just fixing the typo, this removes the dead field entirely.Removed
raw: bytes = b""from theEventdataclass along with all related assignments inunix_console.py,windows_console.py, andbase_eventqueue.py. Theflush_buf()calls are kept since they still need to clear the internal buffer, just no longer pass the result toEvent.Tests updated to match.
Event.rawbeing added to itself instead of to another event's.rawinUnixConsole.getpending#145886