Skip to content

Expand fuzz_pycompile.dict for modern syntax #145942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmlarson merged 2 commits into from
Mar 15, 2026
Merged

Expand fuzz_pycompile.dict for modern syntax #145942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4207ee
Expand `fuzz_pycompile.dict`
StanFromIreland Mar 14, 2026
2233973
Merge branch 'main' into fuzz_pycompile.dict
StanFromIreland Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions Modules/_xxtestfuzz/dictionaries/fuzz_pycompile.dict
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@

# whitespace
" "
"\\t"
":\\n "
"\\\n"
Copy link
Contributor

@eendebakpt eendebakpt Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanFromIreland I am seeing some fuzzing errors on my branch related to this change:

https://github.com/python/cpython/actions/runs/23167480851/job/67311144393?pr=146033

For some reason I do not see the same errors on other PRs. I tried tracing where the fuzzer parses the entries, and ended up here:

https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/fuzzer/FuzzerUtil.cpp#L81

There I see no parsing of \n, but I could be wrong

Copy link
Member Author

@StanFromIreland StanFromIreland Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, it should be "\\\\n".

Copy link
Member Author

@StanFromIreland StanFromIreland Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also in todays build: https://oss-fuzz-build-logs.storage.googleapis.com/log-3341d39d-23f7-43dc-aeae-2509072fc818.txt#:~:text=Step%20%2340%20%2D%20%22build%2Dcheck%2Dlibfuzzer%2Dundefined%2Dx86%5F64%22%3A%20ParseDictionaryFile%3A%20error%20in%20line%2057

Copy link
Member Author

@StanFromIreland StanFromIreland Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote: #146069


# type signatures and functions
"-> "
Expand Down Expand Up @@ -88,6 +90,8 @@
# variable names
"x"
"y"
"_"
"*x"

# strings
"r'x'"
Expand All @@ -98,12 +102,24 @@

"br\"x\""

"u\"x\""

"f'{x + 5}'"
"f\"{x + 5}\""
"f'{s!r}'"
"f'{s!s}'"
"f'{s!a}'"
"f'{x=}'"

"t'{s + 5}'"
"t\"{s + 5}\""
"tr's'"
"rt\"s\""

"'''"
"\"\"\""

"\\N"
"\\u"
"\\x"

Expand Down Expand Up @@ -131,6 +147,7 @@
"while "
"try: "
"except "
"except* "
"finally: "
"with "
"lambda "
Expand All @@ -148,6 +165,10 @@
"in "
"is "
"class "
"match "
"case "
"type "
"lazy "

# shebangs and encodings
"#!"
Expand Down
Loading