gh-143300: implement PyUnstable_SetImmortal
#144543
Conversation
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
I think we also need to document the guarantees regarding which objects may be made immortal. For example, the following results in an assertion failure:
from ctypes import pythonapi, py_object, c_int
set_immortal = pythonapi.PyUnstable_SetImmortal
set_immortal.argtypes = (py_object,)
set_immortal.restype = c_int
print(set_immortal("Hello world"))
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
Looks pretty good.
Bikeshedding: Should this be named PyUnstable_Object_SetImmortal? The Py[Unstable]_ prefix is generally reserved for runtime operations (though it seems PyUnstable_TryIncRef didn't follow that rule).
| creates it, such as in the object's :c:member:`~PyTypeObject.tp_new` slot. | ||
| Returns 1 if the object was made immortal and returns 0 if it was not. | ||
| This function cannot fail. | ||
There was a problem hiding this comment.
Up to you, but it's likely worth mentioning that this is useful for avoiding reference count contention.
I'd like to keep it aligned with |
| made mortal once again. Immortal objects do not participate in reference counting | ||
| and will never be garbage collected. |
There was a problem hiding this comment.
Oh, we also need to note that op will be GC-untracked if it's tracked.
There was a problem hiding this comment.
Isn't it the same as never garbage collected?
4 participants
📚 Documentation preview 📚: https://cpython-previews--144543.org.readthedocs.build/