gh-123471: Make concurrent iteration over itertools.islice thread-safe #144528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make
itertools.islicesafe under free-threading (e.g. guard against crashes) by:cntandnextstepfield as a sentinel for iterator exhaustionNote: several other iterators in the
itertoolsmodule have been made safe using a critical section (e.g. #144402). That approach works here as well and would make the approach a bit more uniform and more readable. Downside of a critical section it that is scales less well.