gh-144424: Clean up dead weakrefs to sqlite3 Blob objects #144435
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
requested review from
berkerpeksag and
erlend-aasland
as code owners
| _pysqlite_drop_unused_blob_references(pysqlite_Connection* self) | ||
| { | ||
| /* we only need to do this once in a while */ | ||
| if (self->created_blobs++ < 200) { |
Member
There was a problem hiding this comment.
If we open new blobs without closing them, we will spend quadratic time on making copy of the list. We can avoid this if make the threshold proportional to the size of the list.
Suggested change
| if (self->created_blobs++ < 200) { | |
| self->created_blobs++; | |
| if (self->created_blobs < 200 || self->created_blobs < PyList_GET_SIZE(self->blobs) / 4) { |
(the coefficient can be different).
| for (Py_ssize_t i = 0; i < imax; i++) { | ||
| PyObject* weakref = PyList_GET_ITEM(self->blobs, i); | ||
| if (_PyWeakref_IsDead(weakref)) { | ||
| continue; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
conn.blobopen()puts a weakref to the new blob object into a list, but dead weakrefs are never cleaned up.This adds a check to go through and clean up dead weakrefs on every 200th blob opened, closely based on the code I removed in #144378 doing the same thing for Cursor weakrefs.
Closes #144424.