gh-144386: Add support for descriptors in ExitStack and AsyncExitStack #144420
+209
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itStack __enter__(), __exit__(), __aenter__(), and __aexit__() can now be arbitrary descriptors, not only normal methods, for consistency with the "with" and "async with" statements.
serhiy-storchaka
force-pushed
the
exit-stack-descriptors
branch
from
b9d6d32 to
bfa8dd3
Compare
ncoghlan
reviewed
Feb 3, 2026
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
The general approach looks right to me, but is it feasible to avoid adding the dependency on the inspect module by moving that helper function somewhere lower in the import stack?
ncoghlan
approved these changes
Feb 4, 2026
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
In the absence of a Python binding for the actual special method lookup logic, the lazy import looks like a reasonable mitigation to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__enter__(),__exit__(),__aenter__(), and__aexit__()can now be arbitrary descriptors, not only normal methods, for consistency with the "with" and "async with" statements.ExitStack.enter_context#144386