gh-142830: prevent some crashes when mutating sqlite3 callbacks
#143245
+407
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
requested review from
a team,
AA-Turner,
berkerpeksag,
emmatyping and
erlend-aasland
as code owners
picnixz
added
topic-sqlite3
needs backport to 3.13
Member
Author
|
Actually, I'm a bit worried about backporting the change to 3.13 and 3.14 because we are now using a real heap type. |
picnixz
added
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 4dd0652 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143245%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
picnixz
commented
Dec 29, 2025
| class Handler: | ||
| def __call__(self, statement): | ||
| # clear the progress handler | ||
| self.cx.set_progress_handler(None, 1) |
Member
Author
There was a problem hiding this comment.
Ups wrong test. I'll amend this tomorrow.
picnixz
commented
Dec 29, 2025
|
|
||
| #define pysqlite_CallbackContext_CAST(op) ((pysqlite_CallbackContext *)(op)) | ||
|
|
||
| /* Allocate a UDF/callback context structure. In order to ensure that the state |
Member
Author
There was a problem hiding this comment.
This comment is outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete fix because there are other callbacks that need to be tested. I could technically split the PR into two but I preferred testing the conversion to
PyObject *in the same PR.sqlite3progress handler via re-entrant__bool__#142830