Skip to content

gh-142555: Fix null pointer dereference in array.__setitem__ via re-entrant __index__ #142713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 22 commits into from
Feb 2, 2026
Merged

gh-142555: Fix null pointer dereference in array.__setitem__ via re-entrant __index__ #142713

encukou merged 22 commits into from
Feb 2, 2026
+107 −1

Conversation

@aisk
Copy link
Contributor

@aisk aisk commented Dec 14, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 14, 2025
Closed
picnixz
picnixz reviewed Dec 14, 2025
View reviewed changes
@aisk aisk marked this pull request as draft December 17, 2025 17:08
@aisk aisk mentioned this pull request Dec 17, 2025
Closed
@aisk aisk marked this pull request as ready for review December 18, 2025 16:51
picnixz
picnixz previously requested changes Dec 27, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Dec 27, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aisk @picnixz
Update Misc/NEWS.d/next/Library/2025-12-15-02-02-45.gh-issue-142555.E…
e865d0d 
…C9QN_.rst

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz dismissed their stale review December 27, 2025 16:49

Changes were addressed

@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 27, 2025
picnixz
picnixz reviewed Dec 27, 2025
View reviewed changes
picnixz
picnixz reviewed Dec 27, 2025
View reviewed changes
picnixz
picnixz reviewed Dec 27, 2025
View reviewed changes
@aisk @picnixz
Update Lib/test/test_array.py
37ed8f8 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
picnixz reviewed Jan 1, 2026
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this is as is, or did you have something else in mind @serhiy-storchaka?

@encukou
Copy link
Member

encukou commented Feb 2, 2026

I'll merge; feel free to follow up in a new PR.

@encukou encukou merged commit 39f16a9 into python:main Feb 2, 2026
50 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 2, 2026

Thanks @aisk for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2026
@aisk @miss-islington
pythongh-142555: Fix null pointer dereference in array.__setitem__ vi…
0887ee2 
…a re-entrant __index__ (pythonGH-142713)

(cherry picked from commit 39f16a9)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 2, 2026
@aisk @miss-islington
pythongh-142555: Fix null pointer dereference in array.__setitem__ vi…
f4aae22 
…a re-entrant __index__ (pythonGH-142713)

(cherry picked from commit 39f16a9)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2026

GH-144396 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 2, 2026
@bedevere-app
Copy link

bedevere-app bot commented Feb 2, 2026

GH-144397 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 2, 2026
@aisk aisk deleted the npd-array-setitem branch February 2, 2026 14:46
Yhg1s pushed a commit that referenced this pull request Feb 2, 2026
@miss-islington @aisk
[3.13] gh-142555: Fix null pointer dereference in array.__setitem__ v…
b74e3a4 
…ia re-entrant __index__ (GH-142713) (#144397)

gh-142555: Fix null pointer dereference in array.__setitem__ via re-entrant __index__ (GH-142713)
(cherry picked from commit 39f16a9)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Feb 3, 2026
@miss-islington @aisk
[3.14] gh-142555: Fix null pointer dereference in array.__setitem__ v…
72ec166 
…ia re-entrant __index__ (GH-142713) (#144396)

gh-142555: Fix null pointer dereference in array.__setitem__ via re-entrant __index__ (GH-142713)
(cherry picked from commit 39f16a9)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
Aniketsy pushed a commit to Aniketsy/cpython that referenced this pull request Feb 3, 2026
@aisk @Aniketsy
pythongh-142555: Fix null pointer dereference in array.__setitem__ vi…
4ffc8fe 
…a re-entrant __index__ (pythonGH-142713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@picnixz picnixz picnixz approved these changes

@StanFromIreland StanFromIreland StanFromIreland left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aisk @encukou @hugovk @serhiy-storchaka @picnixz @StanFromIreland