Skip to content

gh-142302: Fix mkstemp() documentation: clarify file descriptor inheritance behavior #142338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raixyzaditya wants to merge 11 commits into
base: main
Choose a base branch
from
Open

gh-142302: Fix mkstemp() documentation: clarify file descriptor inheritance behavior #142338

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
660a89a
Fix mkstemp() documentation regarding fd inheritance
raixyzaditya Dec 6, 2025
6cba2c6
Fix indentation in mkstemp() documentation
raixyzaditya Dec 6, 2025
220c5d0
Simplify mkstemp() fd inheritance documentataion. Based on code revie…
raixyzaditya Dec 8, 2025
667e5b6
Clarify mkstemp() fd inheritance is specific to exec() calls
raixyzaditya Dec 8, 2025
f574081
Remove accidentally committed backup file
raixyzaditya Dec 9, 2025
090d058
Add link to the detailed
raixyzaditya Dec 9, 2025
000e800
Clarify fd inheritance: fork vs exec in both docs
raixyzaditya Dec 9, 2025
8ecbaa7
Clarify fd inheritance behavior for fork vs exec
raixyzaditya Dec 9, 2025
fae61fc
Clearning the Lint error
raixyzaditya Dec 9, 2025
5cb0e22
Simplifying changes in tempfile.rst file regarding fork/exec explanation
raixyzaditya Dec 17, 2025
28a1791
Simplifying Documentation
raixyzaditya Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Doc/library/tempfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,10 @@ The module defines the following user-callable items:
properly implements the :const:`os.O_EXCL` flag for :func:`os.open`. The
file is readable and writable only by the creating user ID. If the
platform uses permission bits to indicate whether a file is executable,
the file is executable by no one. The file descriptor is not inherited
by child processes.
the file is executable by no one.
Copy link
Member

@vstinner vstinner Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected a simpler change, just add a link to FD inheritance:

(...) The file descriptor is :ref:`not inherited
by child processes <fd_inheritance>`.


The file descriptor is not inherited by child processes across
:func:`exec <os.execl>` calls.
Copy link
Member

@vstinner vstinner Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested to add a link to https://docs.python.org/dev/library/os.html#fd-inheritance and clarify https://docs.python.org/dev/library/os.html#fd-inheritance about fork vs exec.


Unlike :func:`TemporaryFile`, the user of :func:`mkstemp` is responsible
for deleting the temporary file when done with it.
Expand Down
Loading
Loading