-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-141805: avoid increase the set->used twice when the __eq__ trigger another add #142007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kemingy
wants to merge
6
commits into
python:main
Choose a base branch
from
kemingy:gh-141805
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er add Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
dr-carlos
suggested changes
Nov 27, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-11-27-17-47-09.gh-issue-141805.TT0biF.rst
Show resolved
Hide resolved
Signed-off-by: Keming <kemingy94@gmail.com>
Member
efimov-mikhail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks correct for me, just little nitpicks.
Misc/NEWS.d/next/Core_and_Builtins/2025-11-27-17-47-09.gh-issue-141805.TT0biF.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Keming <kemingy94@gmail.com>
efimov-mikhail
approved these changes
Dec 22, 2025
Member
efimov-mikhail
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting core review
needs backport to 3.13
bugs and security fixes
needs backport to 3.14
bugs and security fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-141805: goes directly to the
found_unused_or_dummywhen finding a dummy slot in set.addThis avoids triggering the
__eq__in the next iteration by thePyObject_RichCompareBool, which might introduce anotherset.addin the user code. Like:As described in #141805 (comment)