Skip to content

Conversation

@mokurin000
Copy link

@mokurin000 mokurin000 commented Nov 8, 2025

In time.sleep documentation, we referred a kernel API available from Windows 8.1, while CPython runs in userspace.

It's replaced to the correct MSDN documentation and the first supported and documented version was Windows 10


📚 Documentation preview 📚: https://cpython-previews--141248.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-bot bot commented Nov 8, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland changed the title gh-141246: update windows documentation for high-resolution timer gh-141246: Link to correct Windows docs in time.sleep() doc Nov 8, 2025
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 8, 2025
@vstinner vstinner merged commit 6545a4e into python:main Nov 8, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Nov 8, 2025
@miss-islington-app
Copy link

Thanks @mokurin000 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2025
…ythonGH-141248)

(cherry picked from commit 6545a4e)

Co-authored-by: 莯凛 <1348292515@qq.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 8, 2025

GH-141251 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 8, 2025
…ythonGH-141248)

(cherry picked from commit 6545a4e)

Co-authored-by: 莯凛 <1348292515@qq.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 8, 2025

GH-141252 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 8, 2025
@StanFromIreland
Copy link
Member

Thanks @mokurin000 for the fix and thanks @vstinner for merging!

@vstinner
Copy link
Member

vstinner commented Nov 8, 2025

Merged, thanks.

vstinner pushed a commit that referenced this pull request Nov 8, 2025
…H-141248) (#141251)

gh-141246: Link to correct Windows docs in `time.sleep()` doc (GH-141248)
(cherry picked from commit 6545a4e)

Co-authored-by: 莯凛 <1348292515@qq.com>
vstinner pushed a commit that referenced this pull request Nov 8, 2025
…H-141248) (#141252)

gh-141246: Link to correct Windows docs in `time.sleep()` doc (GH-141248)
(cherry picked from commit 6545a4e)

Co-authored-by: 莯凛 <1348292515@qq.com>
@mokurin000
Copy link
Author

Thanks @StanFromIreland for the review and thanks @vstinner for merging! 🚀

@mokurin000 mokurin000 deleted the patch-1 branch November 8, 2025 15:03
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Documentation about Windows high-resolution timer is wrong

3 participants