Docs: Clarify Windows version for high-resolution timer #140978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Windows version reference in time.rst
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation for the time.sleep() function to reflect more accurate Windows implementation details. The changes specify the exact Windows version where high-resolution timer support was introduced and update the reference link to point to the specific API documentation.
- Updated Windows version requirement from "Windows 8.1 and newer" to "Windows 10 version 1803, and later"
- Changed the high-resolution timer documentation link from the general kernel timers page to the specific
CreateWaitableTimerExWAPI reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
trim21
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip issue
the referenced link is for driver but not userland application and we are not using that API, change it to the correct docs and correct the windows version range (which comes from windows's docs)
here is the corresponding code:
cpython/Modules/timemodule.c
Line 2318 in 947bb46
📚 Documentation preview 📚: https://cpython-previews--140978.org.readthedocs.build/