Correct Glossary key function example to use str.casefold instead of str.lower #140316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…str.lower The glossary currently states: “the str.lower() method can serve as a key function for case-insensitive sorts.” I believe this should be updated to use str.casefold() instead. str.casefold() is recommended for case-insensitive matching in Unicode, and it provides more accurate behavior across languages than str.lower(). This also aligns with the "Sorting Techniques" section of the docs, which uses str.casefold() as the key function for case-insensitive sorting.
|
All commit authors signed the Contributor License Agreement. |
StanFromIreland
approved these changes
Oct 19, 2025
hugovk
added
awaiting core review
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…str.lower (pythonGH-140316) (cherry picked from commit 190aa9f) Co-authored-by: Cameron Beck <94604154+cbkinase@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
…str.lower (pythonGH-140316) (cherry picked from commit 190aa9f) Co-authored-by: Cameron Beck <94604154+cbkinase@users.noreply.github.com>
|
GH-142806 is a backport of this pull request to the 3.13 branch. |
|
GH-142807 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glossary currently states:
“the
str.lower()method can serve as a key function for case-insensitive sorts.”I believe this should be updated to use
str.casefold()instead.str.casefold()is recommended for case-insensitive matching in Unicode, and it provides more accurate behavior across languages thanstr.lower(). This also aligns with the "Sorting Techniques" section of the docs, which usesstr.casefold()as the key function for case-insensitive sorting.📚 Documentation preview 📚: https://cpython-previews--140316.org.readthedocs.build/