-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-135056: Add a --header CLI argument to http.server #135057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0d02fbe
1838da7
a3256fd
77b5fff
5f89c97
a3243fe
b1026d2
6f88c13
7a793f2
9450b86
5a30d91
d317cc2
5f1fb94
c376a71
89a89f0
9653710
f3ae904
44efbed
d47c5a7
8d1286a
db9de68
e149708
c16f4c9
777b5b6
eac5c6a
c9c8083
c2d6bb3
3377cf7
06a9977
fae21f9
be78515
53965ff
c280ed8
64122df
f0d1bac
e99780e
2e829bb
8baa875
7856d27
303ab5b
ed0b0b3
79c577b
526e499
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -699,10 +699,11 @@ class SimpleHTTPRequestHandler(BaseHTTPRequestHandler): | |
| '.xz': 'application/x-xz', | ||
| } | ||
|
|
||
| def __init__(self, *args, directory=None, **kwargs): | ||
| def __init__(self, *args, directory=None, extra_response_headers=None, **kwargs): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think it's important for instances to know whether extra_response_headers was specified (and empty) or was left unspecified? I would say "no", but this may decide whether we want to allow extensibility or not (with None, it allows instances to decide whether what is given at construction time is the default or explicitly "no headers").
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suppose you are considering an alternative where we don't specify I included |
||
| if directory is None: | ||
| directory = os.getcwd() | ||
| self.directory = os.fspath(directory) | ||
| self.extra_response_headers = extra_response_headers | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| def do_GET(self): | ||
|
|
@@ -720,6 +721,12 @@ def do_HEAD(self): | |
| if f: | ||
| f.close() | ||
|
|
||
| def _send_extra_response_headers(self): | ||
| """Send the headers stored in self.extra_response_headers""" | ||
| if self.extra_response_headers is not None: | ||
| for header, value in self.extra_response_headers: | ||
| self.send_header(header, value) | ||
|
|
||
| def send_head(self): | ||
| """Common code for GET and HEAD commands. | ||
|
|
||
|
|
@@ -802,6 +809,7 @@ def send_head(self): | |
| self.send_header("Content-Length", str(fs[6])) | ||
| self.send_header("Last-Modified", | ||
| self.date_time_string(fs.st_mtime)) | ||
| self._send_extra_response_headers() | ||
| self.end_headers() | ||
| return f | ||
| except: | ||
|
|
@@ -866,6 +874,7 @@ def list_directory(self, path): | |
| self.send_response(HTTPStatus.OK) | ||
| self.send_header("Content-type", "text/html; charset=%s" % enc) | ||
| self.send_header("Content-Length", str(len(encoded))) | ||
| self._send_extra_response_headers() | ||
| self.end_headers() | ||
| return f | ||
|
|
||
|
|
@@ -974,25 +983,33 @@ def _get_best_family(*address): | |
| return family, sockaddr | ||
|
|
||
|
|
||
| def _make_server(HandlerClass=BaseHTTPRequestHandler, | ||
picnixz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ServerClass=ThreadingHTTPServer, | ||
| protocol="HTTP/1.0", port=8000, bind=None, | ||
| tls_cert=None, tls_key=None, tls_password=None): | ||
| ServerClass.address_family, addr = _get_best_family(bind, port) | ||
| HandlerClass.protocol_version = protocol | ||
|
|
||
| if tls_cert: | ||
| return ServerClass(addr, HandlerClass, certfile=tls_cert, | ||
| keyfile=tls_key, password=tls_password) | ||
| else: | ||
| return ServerClass(addr, HandlerClass) | ||
|
|
||
|
|
||
| def test(HandlerClass=BaseHTTPRequestHandler, | ||
| ServerClass=ThreadingHTTPServer, | ||
| protocol="HTTP/1.0", port=8000, bind=None, | ||
| tls_cert=None, tls_key=None, tls_password=None): | ||
| """Test the HTTP request handler class. | ||
|
|
||
| This runs an HTTP server on port 8000 (or the port argument). | ||
|
|
||
| """ | ||
| ServerClass.address_family, addr = _get_best_family(bind, port) | ||
| HandlerClass.protocol_version = protocol | ||
|
|
||
| if tls_cert: | ||
| server = ServerClass(addr, HandlerClass, certfile=tls_cert, | ||
| keyfile=tls_key, password=tls_password) | ||
| else: | ||
| server = ServerClass(addr, HandlerClass) | ||
|
|
||
| with server as httpd: | ||
| with _make_server( | ||
| HandlerClass=HandlerClass, ServerClass=ServerClass, | ||
| protocol=protocol, port=port, bind=bind, | ||
| tls_cert=tls_cert, tls_key=tls_key, tls_password=tls_password | ||
| ) as httpd: | ||
| host, port = httpd.socket.getsockname()[:2] | ||
| url_host = f'[{host}]' if ':' in host else host | ||
| protocol = 'HTTPS' if tls_cert else 'HTTP' | ||
|
|
@@ -1031,6 +1048,10 @@ def _main(args=None): | |
| parser.add_argument('port', default=8000, type=int, nargs='?', | ||
| help='bind to this port ' | ||
| '(default: %(default)s)') | ||
| parser.add_argument('-H', '--header', nargs=2, action='append', | ||
| metavar=('HEADER', 'VALUE'), | ||
| help='Add a custom response header ' | ||
| '(can be specified multiple times)') | ||
| args = parser.parse_args(args) | ||
|
|
||
| if not args.tls_cert and args.tls_key: | ||
|
|
@@ -1059,7 +1080,8 @@ def server_bind(self): | |
|
|
||
| def finish_request(self, request, client_address): | ||
| self.RequestHandlerClass(request, client_address, self, | ||
| directory=args.directory) | ||
| directory=args.directory, | ||
| extra_response_headers=args.header) | ||
|
|
||
| class HTTPDualStackServer(DualStackServerMixin, ThreadingHTTPServer): | ||
| pass | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -503,8 +503,16 @@ def test_err(self): | |
| self.assertEndsWith(lines[1], '"ERROR / HTTP/1.1" 404 -') | ||
|
|
||
|
|
||
| class CustomHeaderSimpleHTTPRequestHandler(SimpleHTTPRequestHandler): | ||
| extra_response_headers = None | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| kwargs.setdefault('extra_response_headers', self.extra_response_headers) | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
|
|
||
| class SimpleHTTPServerTestCase(BaseTestCase): | ||
| class request_handler(NoLogRequestHandler, SimpleHTTPRequestHandler): | ||
| class request_handler(NoLogRequestHandler, CustomHeaderSimpleHTTPRequestHandler): | ||
| pass | ||
|
|
||
| def setUp(self): | ||
|
|
@@ -861,6 +869,39 @@ def test_path_without_leading_slash(self): | |
| self.assertEqual(response.getheader("Location"), | ||
| self.tempdir_name + "/?hi=1") | ||
|
|
||
| def test_extra_response_headers_list_dir(self): | ||
| with mock.patch.object(self.request_handler, 'extra_response_headers', [ | ||
| ('X-Test1', 'test1'), | ||
| ('X-Test2', 'test2'), | ||
| ]): | ||
| response = self.request(self.base_url + '/') | ||
| self.assertEqual(response.status, 200) | ||
| self.assertEqual(response.getheader("X-Test1"), 'test1') | ||
| self.assertEqual(response.getheader("X-Test2"), 'test2') | ||
|
|
||
| def test_extra_response_headers_get_file(self): | ||
| with mock.patch.object(self.request_handler, 'extra_response_headers', [ | ||
| ('Set-Cookie', 'test1=value1'), | ||
| ('Set-Cookie', 'test2=value2'), | ||
| ('X-Test1', 'value3'), | ||
| ]): | ||
| data = b"Dummy index file\r\n" | ||
| with open(os.path.join(self.tempdir_name, 'index.html'), 'wb') as f: | ||
| f.write(data) | ||
| response = self.request(self.base_url + '/') | ||
| self.assertEqual(response.status, 200) | ||
| self.assertEqual(response.getheader("Set-Cookie"), | ||
| 'test1=value1, test2=value2') | ||
| self.assertEqual(response.getheader("X-Test1"), 'value3') | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ensure 2 blank lines around classes (there is one blank line missing after this)
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 2e829bb |
||
|
|
||
| def test_extra_response_headers_missing_on_404(self): | ||
| with mock.patch.object(self.request_handler, 'extra_response_headers', [ | ||
| ('X-Test1', 'value'), | ||
| ]): | ||
| response = self.request(self.base_url + '/missing.html') | ||
| self.assertEqual(response.status, 404) | ||
| self.assertEqual(response.getheader("X-Test1"), None) | ||
|
|
||
|
|
||
| class SocketlessRequestHandler(SimpleHTTPRequestHandler): | ||
| def __init__(self, directory=None): | ||
|
|
@@ -1409,6 +1450,21 @@ def test_protocol_flag(self, mock_func): | |
| mock_func.assert_called_once_with(**call_args) | ||
| mock_func.reset_mock() | ||
|
|
||
| @mock.patch('http.server.test') | ||
| def test_header_flag(self, mock_func): | ||
| call_args = self.args | ||
| self.invoke_httpd('--header', 'h1', 'v1', '-H', 'h2', 'v2') | ||
| mock_func.assert_called_once_with(**call_args) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need to check this as You can however check bad usages of
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added some new tests to verify exceptions with incorrect header CLI usage in c2d6bb3. I agree that |
||
| mock_func.reset_mock() | ||
|
|
||
| def test_extra_header_flag_too_few_args(self): | ||
| with self.assertRaises(SystemExit): | ||
| self.invoke_httpd('--header', 'h1') | ||
|
|
||
| def test_extra_header_flag_too_many_args(self): | ||
| with self.assertRaises(SystemExit): | ||
| self.invoke_httpd('--header', 'h1', 'v1', 'h2') | ||
|
|
||
| @unittest.skipIf(ssl is None, "requires ssl") | ||
| @mock.patch('http.server.test') | ||
| def test_tls_cert_and_key_flags(self, mock_func): | ||
|
|
@@ -1492,6 +1548,36 @@ def test_unknown_flag(self, _): | |
| self.assertEqual(stdout.getvalue(), '') | ||
| self.assertIn('error', stderr.getvalue()) | ||
|
|
||
| @mock.patch('http.server._make_server', wraps=server._make_server) | ||
| @mock.patch.object(HTTPServer, 'serve_forever') | ||
| def test_extra_response_headers_arg(self, _, mock_make_server): | ||
| server._main( | ||
| ['-H', 'Set-Cookie', 'k=v', '-H', 'Set-Cookie', 'k2=v2:v3 v4', '8080'] | ||
| ) | ||
| # Get an instance of the server / RequestHandler by using | ||
| # the spied call args, then calling _make_server with them. | ||
| args, kwargs = mock_make_server.call_args | ||
| httpd = server._make_server(*args, **kwargs) | ||
| self.addCleanup(httpd.server_close) | ||
|
|
||
| # Ensure the RequestHandler class is passed the correct response | ||
| # headers | ||
| request_handler_class = httpd.RequestHandlerClass | ||
| with mock.patch.object( | ||
| request_handler_class, '__init__' | ||
| ) as mock_handler_init: | ||
| mock_handler_init.return_value = None | ||
| # finish_request instantiates a request handler class, | ||
| # ensure extra_response_headers are passed to it | ||
| httpd.finish_request(mock.Mock(), '127.0.0.1') | ||
| mock_handler_init.assert_called_once_with( | ||
| mock.ANY, mock.ANY, mock.ANY, | ||
| directory=mock.ANY, | ||
| extra_response_headers=[ | ||
| ['Set-Cookie', 'k=v'], ['Set-Cookie', 'k2=v2:v3 v4'] | ||
| ] | ||
| ) | ||
|
|
||
|
|
||
| class CommandLineRunTimeTestCase(unittest.TestCase): | ||
| served_data = os.urandom(32) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add a ``-H`` or ``--header`` CLI option to :program:`python -m http.server`. Contributed by | ||
| Anton I. Sipos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is me being nitpicky but would it be preferrable to parse
header=valueorheader valueseparate by a space? what about cURL/wget and other CLIs? (I think it's easier not to expect=as you did here because we could always say that-H somethingmeans-H something 1)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a short discussion in the thread on python-ideas with @hugovk about this, see here
In short, cURL and wget do specify headers on their CLI as
--header "name: value". In the python-ideas thread I had opposed using aname:valuesyntax as a positional cli parameter, since it could possibly clash with a port syntax like 127.0.0.1:8000. However if we require an explicit--headeror-Hbefore each "name: value", I'm not opposed to the idea.I think the argument in favor of the PR as it is with
-H <name> <value>is simplicity of implementation - it fits right in with argparse andnargs=2. However, if similarity with cURL / wget is desired it isn't much effort to implement a "name: value" format. I have a draft implementation in a separate branch: see aisipos@d878bf6I'll admit to a slight leaning towards changing to the
name: valueformat, given the principle of least surprise and the popularity of cURL and wget. Thoughts?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the simple space-separated stuff. It will also ease terminal shortcuts where you only delete the previous word (ctrl+w) to change for instance the value of a header. It also simplifies maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@picnixz OK, I'm fine with keeping the space separated / nargs implementation as is in this PR. I think I've made all the other changes you requested. What else remains to do for this PR?