-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-85795: Add support for super() in NamedTuple subclasses
#129352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e84d487
Add support for `super()` in `NamedTuple` subclasses
johnslavik 577bdc7
Rewrite the test to be more neutral
johnslavik b77ea9f
Add a check that `__classcell__` isn't leaked
johnslavik 31f6607
Separate leakage test and mark it as CPython-only
johnslavik 74578e9
Shorten the test name, we know it's a namedtuple test from context
johnslavik 7696b87
We test for dunder class too
johnslavik 2f801dc
Language correctness
johnslavik f8cf62f
Minor aesthetical
johnslavik cc20a2d
Remove unintended attribute access
johnslavik efb9ad2
Encapsulate the `_classcell` parameter
johnslavik d9cdb27
Use a sentinel for missing `__classcell__`
johnslavik 074df4c
Convert new documentation into a `versionchanged` block
johnslavik 998474d
Add a comment discussing reasons for `__classcell__` manipulation
johnslavik ee93519
Reformat for optimal line length
johnslavik e3fc197
Add extra param `stack_offset` for fetching correct frames
johnslavik c2a0c50
Use `next` version ref instead of `3.14`
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-01-27-12-55-40.gh-issue-85795.fnGbGS.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Added support for :func:`super` calls in user-defined | ||
johnslavik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| :class:`~typing.NamedTuple` methods. Contributed by Bartosz Sławecki. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.