Fix type hints in summarize stats #127453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
skip issue
skip news
needs backport to 3.12
ZeroIntensity
approved these changes
Nov 30, 2024
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
We might want to consider running mypy as a part of lint on this in the future, but I doubt it's ready for it's aggressiveness, even with this change. LGTM.
Contributor
Author
|
I think this TODO can also be deleted, can we do it in this PR or should I open another one just for that? |
Member
|
You can open another PR, let's keep this one focused on type hints. |
mdboom
approved these changes
Dec 2, 2024
Contributor
mdboom
left a comment
mdboom
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this.
Contributor
Author
Sure, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZeroIntensity Fixing type hints in summarize stats