-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Tutorial: Update 5.1.2. Using Lists as Queues to include appendleft()
#125138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AdityaKrishnaProjects
wants to merge
4
commits into
python:main
Choose a base branch
from
AdityaKrishnaProjects:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies if the formatting for this pull request isn't correct. In the description for 5.1.2. Using Lists as Queues, within the Data Structures section of the tutorial, the fact that appending and popping to the left of lists is inefficient is mentioned, and that one should instead use the deque object which was designed to have fast appends and pops from both ends. But then in the example code we only have an example for how to remove elements from the left of the list and not add them. It's relatively straightforward that the method is appendleft(), but on first read I assumed that there was no implementation for this in the deque object as I didn't see it in the examples and it seemed to make intuitive sense that one shouldn't add elements to the start of queue.
appendleft()
| 'John' | ||
| >>> queue # Remaining queue in order of arrival | ||
| deque(['Michael', 'Terry', 'Graham']) | ||
| >>> queue.appendleft("John") # John is added to front of queue |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| >>> queue.appendleft("John") # John is added to front of queue | |
| >>> queue.appendleft("John") # John never actually left, add him back |
The comments describe a situation where people are coming/going.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if the formatting for this pull request isn't correct (I couldn't find a valid issue to use for the issue number reference in title, and am not sure how to apply the skip-issue label).
In the description for 5.1.2. Using Lists as Queues, within the Data Structures section of the tutorial, the fact that appending and popping to the left of lists is inefficient is mentioned, and that one should instead use the deque object which was designed to have fast appends and pops from both ends.
But then in the example code we only have an example for how to remove elements from the left of the list and not add them. It's relatively straightforward that the method is appendleft(), but on first read I assumed that there was no implementation for this in the deque object as I didn't see it in the examples and it seemed to make intuitive sense that one shouldn't add elements to the start of queue.
📚 Documentation preview 📚: https://cpython-previews--125138.org.readthedocs.build/en/125138/tutorial/datastructures.html#using-lists-as-queues