Skip to content

Only run diegorusso-aarch64-bigmem on 3.x (aka main)#716

Merged
encukou merged 1 commit intopython:mainfrom
hugovk:diegorusso-aarch64-bigmem-main-only
May 8, 2026
Merged

Only run diegorusso-aarch64-bigmem on 3.x (aka main)#716
encukou merged 1 commit intopython:mainfrom
hugovk:diegorusso-aarch64-bigmem-main-only

Conversation

@hugovk
Copy link
Copy Markdown
Member

@hugovk hugovk commented May 8, 2026

Can we say branches=['3.x']? That'll be better than always tagging on the new branch.

cc @diegorusso

@diegorusso
Copy link
Copy Markdown
Contributor

It's a good idea but we need to change this

if worker.not_branches and branch.name in worker.not_branches:
to manage the match as well.

@hugovk
Copy link
Copy Markdown
Member Author

hugovk commented May 8, 2026

I think that's okay?

Here:

        if worker.not_branches and branch.name in worker.not_branches:
            continue

worker.not_branches is None, so this continue does not run.

Then because branch.name is "3.x" here:

yield BranchInfo(
'3.x',
version_tuple=(3, 16),
git_branch='main',
is_main=True,
builddir_name='3.x',
builder_tag='3.x',
sort_key=-9999,
)

Then here worker.branches == ["3.x"] and also won't run continue when "3.x" in ["3.x"]:

        if worker.branches and branch.name not in worker.branches:
            continue

So the build should be created.

@diegorusso
Copy link
Copy Markdown
Contributor

ok, cool then! I missed that!

Copy link
Copy Markdown
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconfig looks happy!

2026-05-08 14:04:08+0000 [-] Loading configuration from '/srv/buildbot/master/master.cfg'
2026-05-08 14:04:09+0000 [-] adding 0 new builders, removing 1

@encukou encukou merged commit c53cea9 into python:main May 8, 2026
1 check passed
@hugovk hugovk deleted the diegorusso-aarch64-bigmem-main-only branch May 8, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants