Add message with debugging info to Cancelled#3256
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3232 by adding a
CancelReasonthat's tracked by bothCancelScopeandCancelStatusand then used when constructing aCancelledto be raised.Remaining stuff:
CancelScopeandCancelStatusneeds to have aCancelReasonmember - initially onlyCancelStatushad it but that wasn't enough, but I haven't tried to see if I can get away with onlyCancelScopehaving it.CancelScopecs.deadline=-infand then checkpointing somehow ends up as anexplicitcancelled.from_thread_check_cancelledneeds some special handling