You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't like this change (because I install the dependencies using pip install -r test-requirements.txt!), so I'm a -1 here.
My opinion might shift if there's ever a standardized lockfile format though.
presumably one could use uv sync tests for the same effect? I think that might be faster and stuff. But afaict the current setup works fairly well so I don't have strong opinions either way - maybe time to revisit #2790 and see which, if any, of the pain points brought up are still a thing.
Actually, there's a standardized lockfile now. Pip's support for it is in beta, but I figure we can switch to it whenever. In particular, it looks like we can swap pip compile requirements.in --universal -o requirements.txt to uv pip compile requirements.in -o pylock.toml (I don't know if we can do test-requirements.in and docs-requirements.in in the same file...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesPull requests that update a dependency file
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, we switch the CI system to use
uv.lockinstead oftest-requirements.txt.