More specific error message when project name contains disallowed characters#565
Open
MolarFox wants to merge 3 commits intopython-poetry:mainfrom
Open
More specific error message when project name contains disallowed characters#565MolarFox wants to merge 3 commits intopython-poetry:mainfrom
MolarFox wants to merge 3 commits intopython-poetry:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
You've misunderstood something. Not only are hyphens allowed in project names, this very project has a hyphen in its project name: Line 2 in e33e9d1 Also your pull request has nothing much to do with what you've reported: a hyphen is not an uppercase underscore! |
Contributor
|
Perhaps you could usefully include Wants a unit test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Context
Recently I was working on a project using poetry, and ended up in a state where I was unable to use
poetry build, due to getting a "No file/folder found for package <project_name>" error repeatedly, despite the folder structure etc being correct to what poetry expects to seeAfter a bunch of google searching and diving into the source code myself, I was able to see that the cause was that the project name I was using was "molpro-dirman", containing an illegal
-character. Once I sussed this out and changed all the project naming to use an underscore instead, everything worked nominally.In this change I've added an error trap and more specific error message when this case arises for the next person 🙂
Changes
Checklist