Skip to content

Conversation

@radarhere
Copy link
Member

#8389 suggests removing add-imaging-libs from setup.py, as it is undocumented.

It was added in #3399 to allow use when building in AppVeyor. It is no longer used there.

It was also not included when #7171 made sure that other setup options would work with pip >= 23.3 (released October 16, 2023), so it no longer works with recent versions of pip.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: Co-authored-by can be used to give credit to the original author:

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

Or even cherry pick if it's a clean commit.

@radarhere radarhere merged commit bc0e2c0 into python-pillow:main Jan 3, 2026
73 checks passed
@radarhere radarhere deleted the add-imaging-libs branch January 3, 2026 09:19
@radarhere
Copy link
Member Author

I attempted to cherry-pick, but it wasn't working for me. I do tend to forget about 'Co-authored-by', but thankfully, I was able to do that with 'Squash and merge'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants