Raise error if ImageGrab subprocess gives non-zero returncode#9321
Open
radarhere wants to merge 2 commits intopython-pillow:mainfrom
Open
Raise error if ImageGrab subprocess gives non-zero returncode#9321radarhere wants to merge 2 commits intopython-pillow:mainfrom
radarhere wants to merge 2 commits intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9070 (comment) suggested checking the subprocess return code in ImageGrab. This PR adds it, following the example of
Pillow/src/PIL/GifImagePlugin.py
Lines 909 to 910 in b0a5bc2
I've also added additional testing, as per #9070 (comment), including opening a new window on macOS to test capturing it. To avoid interfering too much with user machines though, this will only happen on CIs.