Skip to content

Perf: Optimize string concatenation in parse_uncertainty #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohasarc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Perf: Optimize string concatenation in parse_uncertainty #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion periodictable/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def parse_uncertainty(s):
# e.g., 23.0035(12) but not 23(1) or 23.0(1.0) or 23(1.0)
if '.' not in unc and '.' in value:
zeros = len(value.split('.')[1]) - len(unc)
unc = "0." + ("0"*zeros) + unc
unc = "".join(["0.", "0" * zeros, unc])
return float(value), float(unc)

# Plain value with no uncertainty
Expand Down