Add additional meta data to schema and errors#120
Open
danielbradburn wants to merge 8 commits intopython-openapi:masterfrom
Open
Add additional meta data to schema and errors#120danielbradburn wants to merge 8 commits intopython-openapi:masterfrom
danielbradburn wants to merge 8 commits intopython-openapi:masterfrom
Conversation
…store schema in errors. This gives us the ability to provide additional context when an error occurs, for example if the schema is named then the name of the schema, or if the yaml is parsed with ruamel.yaml we can show the line and column number that generated the error.
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=========================================
+ Coverage 96.19% 97.8% +1.61%
=========================================
Files 54 54
Lines 1444 1457 +13
=========================================
+ Hits 1389 1425 +36
+ Misses 55 32 -23
Continue to review full report at Codecov.
|
…converted to a string without error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds additional information in the schema object (name and dered) and additional stores a reference in schema errors to the schema that caused the error. This gives us the ability to provide additional context when an error occurs, for example if the schema is named then the name of the schema, or if the yaml is parsed with ruamel.yaml we can show the line and column number that generated the error.