Allow sending 0-byte DATA frames when flow-control window is negative#1314
Open
lagemeet wants to merge 1 commit intopython-hyper:masterfrom
Open
Allow sending 0-byte DATA frames when flow-control window is negative#1314lagemeet wants to merge 1 commit intopython-hyper:masterfrom
lagemeet wants to merge 1 commit intopython-hyper:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix empty 0-byte DATA frame broke with FlowControlError
error
Cannot send 0 bytes, flow control window is -49151RFC allows empty END_STREAM even if window is negative
allow 0-byte frames even when window < 0
only enforce flow-control check if frame_size > 0
skip negative window assert for empty payload in connection.py + stream.py