Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Nov 19, 2025

Before, the contrast ratio is 3.1:

image image

After, it's above the min 4.5 recommended by WCAG:

image image

This colour is also used here, should we change that too?

.card:target {
  scroll-margin-top: 4.5rem;
  border-color: #1595fe;
}

📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/159/merge/

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This colour is also used here, should we change that too?

I don't have a preference here, the difference is quite small. I'll leave it up to you.

@merwok
Copy link
Collaborator

merwok commented Nov 19, 2025

I would change it! I added these card title anchors and used the same colour as other links.

@hugovk
Copy link
Member Author

hugovk commented Nov 20, 2025

Changed!

@StanFromIreland StanFromIreland merged commit 414047b into main Nov 20, 2025
4 of 5 checks passed
@StanFromIreland StanFromIreland deleted the contrast branch November 20, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants