-
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: always show the leaderboard even if the provided user isn't in the leaderboard #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: always show the leaderboard even if the provided user isn't in the leaderboard #166
Conversation
756835a to
6e899bb
Compare
decorator-factory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not tested, but changes don't look like they'll break bot.
Conditional approval on fix's bool annotation comments.
Less concerned about consistent quote usage and my minor nitpick, so those can be passed on.
e5344e6 to
71446b7
Compare
|
Resolved! 👍 |
…the leaderboard closes python-discordGH-137
- whitespace around ifs - update quotes, remove typehint - remove unnecessary type arg
71446b7 to
bdb5953
Compare
closes GH-137