Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 12 12
Lines 1731 1731
Branches 216 216
=======================================
Hits 1730 1730
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates contributor/agent documentation in AGENTS.md to better reflect existing local-testing workflows (Make targets and scripts/test-local.sh options) used across Cachier’s multi-backend test matrix.
Changes:
- Document additional
maketargets (test-mongo-inmemory,test-mongo-also-local,services-logs). - Document
scripts/test-local.shparallel options (-p/--parallel,-w/--workers) andCACHIER_TEST_CORESenv var usage.
You can also share your feedback on Copilot code review. Take the survey.
930d569 to
c36971e
Compare
|
@copilot open a new pull request to apply changes based on the comments in this thread |
…larify MongoDB Docker requirement (#366) * Initial plan * docs: fix broken Makefile mongo targets and clarify MongoDB Docker requirement in AGENTS.md Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates contributor/agent documentation for local testing so it matches the repo’s current Makefile targets and the unified scripts/test-local.sh workflow.
Changes:
- Switch MongoDB Makefile targets from the removed
scripts/test-mongo-local.shtoscripts/test-local.sh. - Document additional Makefile targets (
test-mongo-inmemory,test-mongo-also-local,services-logs). - Document
scripts/test-local.shparallel options (-p/--parallel,-w/--workers) and theCACHIER_TEST_CORESworkflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Routes MongoDB Docker/local testing targets through the unified scripts/test-local.sh. |
| AGENTS.md | Expands local-testing docs to include additional Make targets, parallel options, and CACHIER_TEST_CORES usage. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary
Makefilescripts/test-local.shCACHIER_TEST_CORESenvironment-variable workflow exampleWhy
Keep
AGENTS.mdaligned with actual repo workflows/commands so automation and contributors use the same entry points.Changes
make test-mongo-inmemorymake test-mongo-also-localmake services-logs-p/--paralleland-w/--workersoptionsCACHIER_TEST_CORES="mongo redis" ./scripts/test-local.shexample