Skip to content

Prevent SciPy deprecation warning for estimate_gradients_2d_global #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basnijholt merged 2 commits into from
May 13, 2025
Merged

Prevent SciPy deprecation warning for estimate_gradients_2d_global #475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30201e
Prevent SciPy deprecation warning
basnijholt May 13, 2025
3b799e6
Use CloughTocher2DInterpolator
basnijholt May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions adaptive/learner/learner2D.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import cloudpickle
import numpy as np
from scipy import interpolate
from scipy.interpolate import LinearNDInterpolator
from scipy.interpolate import CloughTocher2DInterpolator, LinearNDInterpolator

from adaptive.learner.base_learner import BaseLearner
from adaptive.learner.triangulation import simplex_volume_in_embedding
Expand Down Expand Up @@ -49,9 +49,7 @@ def deviations(ip: LinearNDInterpolator) -> list[np.ndarray]:
The deviation per triangle.
"""
values = ip.values / (np.ptp(ip.values, axis=0).max() or 1)
gradients = interpolate.interpnd.estimate_gradients_2d_global(
ip.tri, values, tol=1e-6
)
gradients = CloughTocher2DInterpolator(ip.tri, values, tol=1e-6).grad

simplices = ip.tri.simplices
p = ip.tri.points[simplices]
Expand Down
Loading