fix(python_api): correct hasattr call for __array_interface__ check#14459
Open
Hrk84ya wants to merge 2 commits intopytest-dev:mainfrom
Open
fix(python_api): correct hasattr call for __array_interface__ check#14459Hrk84ya wants to merge 2 commits intopytest-dev:mainfrom
Hrk84ya wants to merge 2 commits intopytest-dev:mainfrom
Conversation
…ng "obj" Closes pytest-dev#14456 The second hasattr call in _as_numpy_array incorrectly passed the string literal "obj" instead of the variable obj when checking for __array_interface__. This caused objects implementing only __array_interface__ (without __array__) to not be recognized as numpy-like arrays by pytest.approx. Co-authored-by: Kiro (AI) <noreply@kiro.dev>
psf-chronographer
Bot
added
the
bot:chronographer:provided
There was a problem hiding this comment.
Pull request overview
Fixes a bug in pytest’s approx NumPy-detection logic where _as_numpy_array accidentally checked __array_interface__ on the string literal "obj" instead of the actual object, preventing some array-like objects from being treated as NumPy-like.
Changes:
- Corrected the
hasattrcall to check__array_interface__onobj. - Added a towncrier bugfix fragment documenting the user-visible impact.
- Added the contributor to
AUTHORS.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/_pytest/python_api.py |
Fixes _as_numpy_array detection so pytest.approx recognizes objects implementing __array_interface__. |
changelog/14456.bugfix.rst |
Adds a user-facing changelog entry for the bugfix. |
AUTHORS |
Adds the contributor name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+909
to
910
| elif hasattr(obj, "__array__") or hasattr(obj, "__array_interface__"): | ||
| return np.asarray(obj) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14456
The second hasattr call in _as_numpy_array incorrectly passed the string literal "obj" instead of the variable obj when checking for array_interface. This caused objects implementing only array_interface (without array) to not be recognized as numpy-like arrays by pytest.approx.
Fix typo in hasattr call: change hasattr("obj", ...) to hasattr(obj, ...)
Ensures array_interface attribute is checked on the actual object instead of the string literal "obj"
Prevents incorrect behavior when converting objects to numpy arrays