fix(python_api): correct hasattr call for __array_interface__ check#14458
Closed
Hrk84ya wants to merge 2 commits intopytest-dev:mainfrom
Closed
fix(python_api): correct hasattr call for __array_interface__ check#14458Hrk84ya wants to merge 2 commits intopytest-dev:mainfrom
Hrk84ya wants to merge 2 commits intopytest-dev:mainfrom
Conversation
Hrk84ya
commented
May 10, 2026
Hrk84ya
commented
- Fix typo in hasattr call: change hasattr("obj", ...) to hasattr(obj, ...)
- Ensures array_interface attribute is checked on the actual object instead of the string literal "obj"
- Prevents incorrect behavior when converting objects to numpy arrays
- Fix typo in hasattr call: change hasattr("obj", ...) to hasattr(obj, ...)
- Ensures __array_interface__ attribute is checked on the actual object instead of the string literal "obj"
- Prevents incorrect behavior when converting objects to numpy arrays
There was a problem hiding this comment.
Pull request overview
Fixes a bug in pytest’s internal NumPy interoperability used by pytest.approx, ensuring array-like objects are detected correctly when they implement NumPy’s legacy __array_interface__ protocol.
Changes:
- Corrects the
hasattrcall to check__array_interface__on the actual input object rather than the string literal"obj".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+909
to
910
| elif hasattr(obj, "__array__") or hasattr(obj, "__array_interface__"): | ||
| return np.asarray(obj) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.