Fix _as_numpy_array: use variable obj instead of string literal "obj"#14457
Closed
quick123-666 wants to merge 2 commits intopytest-dev:mainfrom
Closed
Fix _as_numpy_array: use variable obj instead of string literal "obj"#14457quick123-666 wants to merge 2 commits intopytest-dev:mainfrom
quick123-666 wants to merge 2 commits intopytest-dev:mainfrom
Conversation
Member
|
closing due to ai abuse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes a bug in
_as_numpy_arraywherehasattrwas called with the string literal"obj"instead of the variableobjfor the__array_interface__check.This meant any object implementing
__array_interface__without also implementing__array__would not be recognized as a numpy-like array by_as_numpy_array, causing it to fall through toApproxSequenceLikeinstead ofApproxNumpy. In practice this could affect users with custom array types or libraries that only implement__array_interface__.GitHub Issue Link
Testing Plan
test_numpy_array_via_interface_protocolwhich creates a class implementing__array_interface__without__array__and verifies it works withapprox()test_numpy_array_implicit_conversionandtest_numpy_array_protocolcontinue to pass (they test__array__path)