feat: add worker ramp option#1330
Conversation
|
This deviates from then proposed mechanism as it sidesteps the start later detail As such it's a partial solution to the proposal but also a working solution that has to solve far less problems than a full process ramping solution Its a pretty nice step forward |
@RonnyPfannschmidt any suggested changes to make it an acceptable contribution? |
|
It already is |
|
@RonnyPfannschmidt awesome, this is my first contribution in this repo, what's the approval/merge process? Anything pending on me? |
| # workaround https://github.com/pypy/pypy/issues/2375 | ||
| return 2 | ||
| return None | ||
| if os.environ.get("TRAVIS") == "true": |
There was a problem hiding this comment.
followup note - travis is no longer a thing in direct use - we might want to drop explicit handling for it
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
the workermanage api change is okay as its a internal class
|
sorry for the delays, i'm a bit stretched |
2 participants
Summary
Add
--ramp DURATIONto stagger when xdist workers begin executing tests after collection.Refs #1219.
Checklist
changelog/1219.feature.rstTest Plan
uv run --extra testing pytest testing/test_plugin.py testing/test_workermanage.py testing/test_remote.py testing/acceptance_test.py -quv run --python 3.10 --with pre-commit pre-commit run --files ...