Skip to content

feat: pluggable HTML themes via Jinja2 template inheritance#1030

Draft
RonnyPfannschmidt wants to merge 6 commits into
pytest-dev:masterfrom
RonnyPfannschmidt:html-theming
Draft

feat: pluggable HTML themes via Jinja2 template inheritance#1030
RonnyPfannschmidt wants to merge 6 commits into
pytest-dev:masterfrom
RonnyPfannschmidt:html-theming

Conversation

@RonnyPfannschmidt
Copy link
Copy Markdown
Member

Summary

  • Adds a theme system using a dedicated pytest_html.themes entry point group and an html_theme_path ini option for local overrides
  • Themes provide a layout.jinja2 (extending base.jinja2) and optionally a style.css
  • Ships two built-in themes: classic (current look, default) and modern (card-based dashboard)
  • External packages can register additional themes via the same entry point mechanism

Motivation

Addresses user demand for visual customization (#1029, #1028, #730, #841, #913, #904) without requiring forks. The entry point design means theme packages are pip-installable, while html_theme_path supports local project-level themes with zero packaging overhead.

Usage

# pyproject.toml
[tool.pytest.ini_options]
html_theme = "modern"        # or "classic" (default)
# html_theme_path = "./my_theme"  # local override

Theme authoring

A theme is a Python package directory containing:

  • __init__.py (package marker)
  • layout.jinja2 (required, extends base.jinja2)
  • style.css (optional, replaces default CSS)

Register via entry point:

[project.entry-points."pytest_html.themes"]
my_theme = "my_package.theme"

Test plan

  • Built-in classic theme generates report (backward compat)
  • Modern theme renders card-based dashboard
  • html_theme_path ini option overrides entry points
  • Theme with custom CSS is applied
  • Missing layout.jinja2 raises UsageError
  • Unknown theme name raises UsageError
  • --css flag still appends on top of theme CSS
  • Existing unit tests pass unchanged

Closes #1029

Made with Cursor

Add a theme system using entry_points ("pytest_html.themes") and an
html_theme_path ini option for local overrides. Themes provide a
layout.jinja2 that extends base.jinja2 and optionally a style.css.

Ships two built-in themes: classic (current look, default) and modern
(card-based dashboard). External packages can register additional
themes via the same entry point group.

Closes pytest-dev#1029

Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Anthropic Claude Sonnet 4 <claude@anthropic.com>
Copilot AI review requested due to automatic review settings May 24, 2026 21:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a pluggable HTML theme system for pytest-html using Jinja2 template inheritance, enabling built-in and third-party themes via a new pytest_html.themes entry point group and an html_theme_path local override.

Changes:

  • Adds theme selection/config (html_theme, html_theme_path) and entry-point-based theme discovery.
  • Refactors templates into base.jinja2 plus per-theme layout.jinja2, and splits CSS into theme-specific stylesheets (classic/modern).
  • Adds tests and user documentation covering theme selection, overrides, and CSS behavior.

Reviewed changes

Copilot reviewed 12 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
testing/test_themes.py Adds functional coverage for built-in themes, local theme path overrides, and CSS composition.
src/pytest_html/util.py Switches default template name from index.jinja2 to layout.jinja2 for theme-based rendering.
src/pytest_html/plugin.py Implements theme resolution (ini + entry points) and wires theme template/CSS selection into report generation.
src/pytest_html/resources/base.jinja2 Introduces overridable Jinja blocks to support template inheritance across themes.
src/pytest_html/resources/classic/layout.jinja2 Defines classic theme layout as a thin wrapper extending the base template.
src/pytest_html/resources/classic/style.css Provides the classic theme CSS (generated output).
src/pytest_html/resources/modern/layout.jinja2 Adds modern theme-specific summary/header layout using base template blocks.
src/pytest_html/resources/modern/style.css Provides the modern theme CSS (generated output).
src/layout/css/classic.scss Adds source SCSS for generating classic CSS.
src/layout/css/modern.scss Adds source SCSS for generating modern CSS.
src/.gitattributes Marks theme CSS outputs as generated for GitHub linguist.
pyproject.toml Registers built-in themes via the new pytest_html.themes entry point group.
package.json Updates build scripts to generate per-theme CSS files.
docs/user_guide.rst Documents theme selection, local theme directories, entry-point authoring, and available template blocks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pytest_html/plugin.py Outdated
Comment on lines +111 to +116
eps = importlib.metadata.entry_points(group="pytest_html.themes")
for ep in eps:
if ep.name == theme_name:
theme_module = ep.load()
theme_traversable = importlib.resources.files(theme_module)
return Path(str(theme_traversable))
Comment thread testing/test_themes.py Outdated
Comment on lines +3 to +4
from pathlib import Path

Comment thread src/pytest_html/plugin.py Outdated
if ep.name == theme_name:
theme_module = ep.load()
theme_traversable = importlib.resources.files(theme_module)
return Path(str(theme_traversable))
RonnyPfannschmidt and others added 2 commits May 24, 2026 23:49
- Drop Python 3.9 support (EOL), requires-python bumped to >=3.10
- Validate layout.jinja2 exists in entry-point-resolved theme dirs
- Remove unused Path import in test_themes.py

Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Anthropic Claude Sonnet 4 <claude@anthropic.com>
- Remove unused imports (flake8)
- Replace HTML entity with Unicode literal (djlint)
- Fix test references to moved style.css path
- Drop Python 3.9/pypy3.9 from CI matrix
- Apply pyupgrade --py310-plus (Optional → X | None)
- Update pyupgrade config to --py310-plus

Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Anthropic Claude Sonnet 4 <claude@anthropic.com>
Copilot AI review requested due to automatic review settings May 25, 2026 05:05
Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Anthropic Claude Sonnet 4 <claude@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 23 changed files in this pull request and generated 4 comments.

Comment thread src/pytest_html/plugin.py
Comment on lines +99 to +101
def _resolve_theme(config: pytest.Config, resources_path: Path) -> Path:
theme_name = config.getini("html_theme")

Comment thread testing/test_themes.py
Comment on lines +1 to +9
from __future__ import annotations

pytest_plugins = ("pytester",)


def run(pytester, path="report.html", cmd_flags=None):
cmd_flags = cmd_flags or []
path = pytester.path.joinpath(path)
return pytester.runpytest("--html", path, *cmd_flags)
Comment thread testing/test_themes.py
Comment on lines +79 to +86
def test_theme_path_without_layout_raises_error(self, pytester):
theme_dir = pytester.path / "bad_theme"
theme_dir.mkdir()
pytester.makeini(f"[pytest]\nhtml_theme_path = {theme_dir}\n")
pytester.makepyfile("def test_pass(): pass")
result = run(pytester)
result.stderr.fnmatch_lines(["*does not contain layout.jinja2*"])

Comment thread testing/test_themes.py
def test_unknown_theme_raises_error(self, pytester):
pytester.makeini("[pytest]\nhtml_theme = nonexistent")
pytester.makepyfile("def test_pass(): pass")
result = run(pytester)
@RonnyPfannschmidt
Copy link
Copy Markdown
Member Author

its locally broken, so some test assumption is wrong

@RonnyPfannschmidt
Copy link
Copy Markdown
Member Author

i need to adapt graphic style a bit more, righ now its blocky but functional - the modern theme needs to be made pretty first as wrll

@RonnyPfannschmidt RonnyPfannschmidt marked this pull request as draft May 25, 2026 13:24
Rewrites the modern theme CSS/HTML to match pytest-xhtml aesthetic:
- Result cards with colored top borders and status icons in circles
- Toggle switches replacing plain checkboxes for filters
- Styled buttons (primary/outline) instead of default HTML buttons
- Grid layout placing environment card alongside result cards
- CSS variables for consistent theming
- Explicit ./ prefix on asset paths for file:// compatibility

Co-authored-by: Cursor AI <ai@cursor.sh>
Co-authored-by: Anthropic Claude Sonnet 4 <claude@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: pluggable HTML themes via Jinja2 template inheritance

2 participants