Creates path to json file if it does not exist#347
Open
shawnemhe wants to merge 3 commits intopytest-dev:masterfrom
Open
Creates path to json file if it does not exist#347shawnemhe wants to merge 3 commits intopytest-dev:masterfrom
shawnemhe wants to merge 3 commits intopytest-dev:masterfrom
Conversation
Fixes error when attempting to create a cucumber json in a directory has not been created yet.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 95.80% 95.82% +0.01%
==========================================
Files 57 57
Lines 2217 2227 +10
Branches 185 188 +3
==========================================
+ Hits 2124 2134 +10
Misses 62 62
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @shawnemhe, thank you for this fix. Could you write a test for it too? |
Modified runandparse to check if the new test has added a "missing_subdirectory" attribute. Verified that this doesn't break the functionality of the already existing cucumber tests.
Using a fixture now to run all cucumber tests with and without missing subdirectory. Also fixed formatting issues identified in build test.
Author
|
Hi @youtux, it is testing now by parametrizing the testdir fixture so that of the cucumber tests run with and without a missing subdirectory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change to prevent raising an error when attempting to create a cucumber json in a directory that has not been created yet. This breaks form with the standard pytest --junitxml functionality which would create the path in this situation.