rewired downstream test drivers

.github/workflows/downstream.yml

@@ -0,0 +1,52 @@
+# Downstream checks run on pull requests to main when the head branch name
+# contains "downstream", or any time via workflow_dispatch. For dispatch-only
+# runs: Actions → downstream → Run workflow → pick a branch under "Use workflow from".
+#
+# The workflow must exist on the default branch for it to appear under the
+# upstream repo's Actions tab; until the workflow is merged, use the fork's
+# Actions (or dispatch from a branch that contains this file).
+name: downstream
+
+on:
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - main
+
+permissions: {}
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+  recipe:
+    name: downstream (${{ matrix.recipe }})
+    runs-on: ubuntu-latest
+    timeout-minutes: 120
+    if: >-
+      github.event_name == 'workflow_dispatch'
+      || (github.event_name == 'pull_request' && contains(github.head_ref, 'downstream'))
+    strategy:
+      fail-fast: false
+      matrix:
+        recipe:
+          - conda
+          - datasette
+          - devpi
+          - hatch
+          - pytest
+          - python-lsp-server
+          - tox
+    steps:
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+        with:
+          fetch-depth: 0
+          persist-credentials: false
+      - uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
+        with:
+          python-version: "3.12"
+          allow-prereleases: true
+      - uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
+      - name: Run downstream recipe
+        run: uv run downstream/run_downstream.py "${{ matrix.recipe }}"

RELEASING.rst

@@ -1,9 +1,10 @@
 Release Procedure
 -----------------
 
-#. Dependening on the magnitude of the changes in the release, consider testing
+#. Depending on the magnitude of the changes in the release, consider testing
    some of the large downstream users of pluggy against the upcoming release.
-   You can do so using the scripts in the ``downstream/`` directory.
+   You can do so with ``uv run downstream/run_downstream.py <recipe>``;
+   use ``--list`` to discover available recipes.
 
 #. From a clean work tree, execute::
 

downstream/.gitignore

@@ -3,4 +3,5 @@
 /devpi/
 /hatch/
 /pytest/
+/python-lsp-server/
 /tox/

downstream/README.md

@@ -1,2 +1,29 @@
-This directory contains scripts for testing some downstream projects
-against your current pluggy worktree.
+This directory contains tooling for testing some downstream projects against
+your current pluggy checkout.
+
+Each project is described by a TOML recipe in `recipes/` with three sections:
+
+1. **`[git]`** — repository URL, local directory name (`into`), optional `shallow`
+   (default: shallow clone).
+2. **`[environment]`** — distinguished by structure (no `kind` key needed):
+   - **uv-venv** (has `editables`): creates `uv venv`, installs via
+     `uv pip install`.  `editables` are passed as `-e` args.  Optional
+     `groups` and `packages` for extra dependencies.
+   - **script** (has `run`): delegates bootstrap, install, and test to a
+     bash script (path relative to `downstream/`).  No `[[test]]` steps.
+3. **`[[test]]`** (uv-venv only) — one or more `argv` arrays.  The driver sets
+   **`VIRTUAL_ENV`** and prepends the venv's `bin` to **`PATH`**, so test
+   commands can use bare names like `pytest`.  Optional **`env`** table sets
+   extra environment variables; an empty string removes the variable (e.g.
+   `env = { CI = "" }` to unset `CI`).
+   Install only: `--only-install`.  Skip install: `--skip-install`.
+
+Run the driver (PEP 723 in `run_downstream.py`):
+
+```bash
+uv run downstream/run_downstream.py --list
+uv run downstream/run_downstream.py pytest
+uv run downstream/run_downstream.py pytest --skip-install
+```
+
+Requirements: Python 3.11+ for the driver, `git`, and `uv`.

downstream/recipes/conda.bash

@@ -0,0 +1,22 @@
+#!/usr/bin/env bash
+# Bootstrap, install, and test conda against the local pluggy checkout.
+# Called from run_downstream.py via the conda recipe.
+set -eu
+
+cd "$(dirname "$0")/../conda"
+
+# dev/start needs relaxed error handling during bootstrap.
+set +eu
+source dev/start
+set -eu
+
+# Install pluggy editable from the parent checkout.
+pip install -e ../..
+
+# Mirror conda's own CI condarc-defaults so tests that create temporary
+# environments can resolve packages.
+conda config --add channels defaults
+
+pytest \
+    -m 'not integration and not installed' \
+    --deselect=tests/cli/test_main_export.py::test_export_from_history_format

downstream/recipes/conda.toml

@@ -0,0 +1,7 @@
+[git]
+url = "https://github.com/conda/conda"
+into = "conda"
+shallow = false
+
+[environment]
+run = "recipes/conda.bash"

downstream/recipes/datasette.toml

@@ -0,0 +1,10 @@
+[git]
+url = "https://github.com/simonw/datasette"
+into = "datasette"
+
+[environment]
+editables = [".", "../.."]
+groups = ["dev"]
+
+[[test]]
+argv = ["pytest"]

downstream/recipes/devpi.toml

@@ -0,0 +1,21 @@
+[git]
+url = "https://github.com/devpi/devpi"
+into = "devpi"
+
+[environment]
+editables = ["common", "server", "client", "web", "../.."]
+groups = ["pytest"]
+
+[[test]]
+argv = ["pytest", "common"]
+
+[[test]]
+argv = ["pytest", "server"]
+
+[[test]]
+# Ignore test_upload: upstream conftest bug compares code=[200,200,200]
+# against integers, causing TypeError on every upload-with-docs test.
+argv = ["pytest", "client", "--ignore=client/testing/test_upload.py"]
+
+[[test]]
+argv = ["pytest", "web"]

downstream/recipes/hatch.toml

@@ -0,0 +1,18 @@
+[git]
+url = "https://github.com/pypa/hatch"
+into = "hatch"
+
+[environment]
+editables = [".", "./backend", "../.."]
+packages = [
+    "pytest",
+    "pytest-mock",
+    "pytest-xdist",
+    "filelock",
+    "flit-core",
+    "trustme",
+    "editables",
+]
+
+[[test]]
+argv = ["pytest", "tests/backend"]

downstream/recipes/pytest.toml

@@ -0,0 +1,10 @@
+[git]
+url = "https://github.com/pytest-dev/pytest"
+into = "pytest"
+shallow = false
+
+[environment]
+editables = [".[dev]", "../.."]
+
+[[test]]
+argv = ["pytest"]

downstream/recipes/python-lsp-server.toml

@@ -0,0 +1,15 @@
+[git]
+url = "https://github.com/python-lsp/python-lsp-server.git"
+into = "python-lsp-server"
+
+[environment]
+editables = [".[all,test]", "../.."]
+
+[[test]]
+# Deselect two jedi-environment tests that require /tmp/pyenv/ fixture
+# not provided by the default test environment.
+argv = [
+    "pytest",
+    "--deselect=test/plugins/test_completion.py::test_jedi_completion_environment",
+    "--deselect=test/plugins/test_symbols.py::test_symbols_all_scopes_with_jedi_environment",
+]

downstream/recipes/tox.toml

@@ -0,0 +1,16 @@
+[git]
+url = "https://github.com/tox-dev/tox"
+into = "tox"
+shallow = false
+
+[environment]
+editables = [".[completion]", "../.."]
+groups = ["test"]
+
+[[test]]
+argv = ["pytest"]
+# tox's is_ci() checks presence of CI, value of GITHUB_ACTIONS, and
+# other env vars.  Empty string = remove from environment, non-empty
+# overrides value.  Both must be gone for list_dependencies to default
+# to False and test expectations (no freeze steps, etc.) to hold.
+env = { CI = "", GITHUB_ACTIONS = "" }