feat: add config file support, search pagination, and retry logic#1591
Closed
s1vrn wants to merge 3 commits intopystardust:masterfrom
Closed
feat: add config file support, search pagination, and retry logic#1591s1vrn wants to merge 3 commits intopystardust:masterfrom
s1vrn wants to merge 3 commits intopystardust:masterfrom
Conversation
Collaborator
All in all I'm split on the features, they aren't outright bad. There are a lot of changes (considering the size of the script), so we have to thread carefully as to not accidentally break existing workflows/functionality |
Author
|
Thanks for the detailed feedback! I’ve updated the code and force-pushed to address these points:
I've also updated the help information to reflect these changes. Let me know if everything looks good on your end now! |
Collaborator
|
Unsalvagable imo, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature request
Type of change
Description
Currently,
ani-clihas several usability limitations that this PR addresses:Solutions Implemented:
Search again? [Y/n]. Note: This includes a[ -t 0 ]check to ensure it never hangs in non-interactive/scripted environments.play()function to allow multiple ranges. Users can now skip filler episodes using a command like./ani-cli -e 1-5 -e 10-15 naruto.Alternatives Considered
Additional context
sh -n ani-clipasses (Appeased the linter).ani-cli -hupdated with multi-range examples.debugplayer on large series like "Naruto Shippuden" and "One Piece".Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-e(select episode) aka-r(range selection) works (now supports multiple ranges)-Sselect index works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--exit-after-playauto exit after playing works--nextep-countdowncountdown to next ep works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases
./ani-cli -e 1-2 -e 5-6 "Naruto"-> Successfully skipped eps 3-4.asdfghjkl-> Correctly show error and retry prompt (interactive) or exit (non-interactive).One Piece-> Correctly showed "Next page" at index 41.echo "1" | ./ani-cli -e 1 "Naruto"-> Verified it selects result 1 and plays without prompting "Search again?".